Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tasks): print diff for minify idempotency assertion #8161

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Dec 28, 2024

Made the assertion error output more easier to understand.

Example output:
image

Copy link

graphite-app bot commented Dec 28, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Dec 28, 2024
Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #8161 will not alter performance

Comparing sapphi-red:chore/tasks-print-diff-minify-idenpotency-assertion (f2e5a39) with main (37c9959)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen merged commit 9d62284 into oxc-project:main Dec 28, 2024
27 checks passed
@sapphi-red sapphi-red deleted the chore/tasks-print-diff-minify-idenpotency-assertion branch December 28, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants